Michael Hoffmann
Michael Hoffmann
Hey, I'm trying to incorporate this package into [perkeep](https://github.com/perkeep/perkeep/pull/1610). I cannot get the windows tests to work though, they keep failing with `ErrInvalidFile`, while Linux and MacOS tests work fine....
# Required for all PRs - [ ] Updated associated README.md. - [ ] Wrote appropriate unit tests. - [ ] Pull request title or commits are in [conventional commit...
This is a really minor fix; but the specification does not mention leading underscores `_` as a valid identifier start.
When comparing `https://github.com/gojek/heimdall/blob/master/httpclient/client.go` and `https://github.com/gojek/heimdall/blob/master/hystrix/hystrix_client.go` it seems that they only differ fundamentally in their respective `Do` methods. One could factor that part out into seperate `Doer` implementations and only have...
A small note about an edge case that can lead the described procedure to hang indefinitely if BGSAVE returned the same second that redis started.
address #11337
On big thanos deployments we can have queries that emit several thousand spans. This is clearly not feasible so I propose that we start cleaning up some internal ones and...
* [x] I added CHANGELOG entry for this change. * [ ] Change is not relevant to the end user. ## Changes Mark metas with incomplete files as corrupted. Once...
* [ ] I added CHANGELOG entry for this change. * [ ] Change is not relevant to the end user. ## Changes * replication/remotewrite is handled with vtproto *...
* [ ] I added CHANGELOG entry for this change. * [ ] Change is not relevant to the end user. ## Changes Consider the hash of the full chunk...