Michael Hoffmann
Michael Hoffmann
Closing as all aggregations are added nowadays!
> I am not sure if this belongs in the engine to be fair. We already have this feature in Thanos so we could convert error responses to warnings when...
After quite a while - I agree this should be handled on the thanos side.
> > On second thought, couldnt this be implemented completely in thanos? As in "create context, add stuff during select, read out in api and add to analysis" kinda way?...
Oh it might be that I forgot to merge back to main when releasing 0.38.0! Sorry for that
Do all object storage clients attempt to create the bucket? Edit: I spot checked the s3 provider and it doesnt create a bucket - so this would likely break that,...
> So, in objstore `factory.go`, I see that all objstore call `NewBucket` > > ``` > case string(GCS): > bucket, err = gcs.NewBucket(context.Background(), logger, config, component) > case string(S3): >...
> @bwplotka @GiedriusS has there been any movement on this issue? Could we close this in the meantime if there was no progress? > > _We looked at this at...
> And more recently the [documentation and tests were added](https://github.com/prometheus/prometheus/pull/14849). Do we still need this PR? I don't understand, isn't that PR about label values but this PR is about...
Can you test this in templates too? Otherwise LGTM! Do you want dots in HEREDOC identifiers too? Then you would need to adjust scanner here: https://github.com/tree-sitter-grammars/tree-sitter-hcl/blob/41a2e702413a53f2614533b2aa9c187816116cbc/src/scanner.c#L315 Sorry for long leadtime...