promql-engine icon indicating copy to clipboard operation
promql-engine copied to clipboard

Adjust min/max timestamp in querier

Open GiedriusS opened this issue 1 year ago • 3 comments

Basically, we should port https://github.com/prometheus/prometheus/commit/debbdb8608cdd24e0cfcd1046f04ea4c6abd840e into our engine. It breaks lots of tests.

GiedriusS avatar Sep 19 '24 10:09 GiedriusS

In theory we should be able to do this by modifying the logic in the ringbuffer package and perhaps the prometheus matrix_selector scanner.

fpetkovski avatar Sep 21 '24 08:09 fpetkovski

Is it still blocked by https://github.com/prometheus/prometheus/issues/14961? I see the issue was closed.

yeya24 avatar Oct 02 '24 00:10 yeya24

Looks like that was a false alarm, we can try to update and make the necessary modifications.

fpetkovski avatar Oct 02 '24 05:10 fpetkovski

I think this is done - we are on Prometheus 3 now and we pass acceptance tests ( and all the others ). I'll close - if I misunderstood please reopen though!

MichaHoffmann avatar Mar 02 '25 20:03 MichaHoffmann