Michael Hoffmann

Results 224 comments of Michael Hoffmann

> > Sorry I don't see it - isn't that valid Syntax? > > Of what I searched upon, shouldn't there be any arguments with `count_values`? Also `--` within that...

Can you try this flag please: queryDistributedWithOverlappingInterval := cmd.Flag("query.distributed-with-overlapping-interval", "Allow for distributed queries using an engines lowest MinT.").Hidden().Default("false").Bool()

It's an interesting issue that I think we understand but that's tricky to fix automatically. I hope one day we won't need the flag anymor!

> I am wondering if this needs to be configurable at all? Every option adds mental overhead for users and maintainers. Under what circumstances would I _not_ want to set...

If `r` implements Seeker then we wont ever return a writerTo, right? Is that problematic?

> Should we name it SizeBytes to avoid any kind of confusion over what are the units? Yeah we can do that! Ill also implement it for the other providers...

> Quite a lot of tests failed due to round. Should we add my fix to `round` function to see how much it would help? > > ``` > ---...

Great finding! I wonder - couldn't we handle that in the operator by fetching once, filtering and then just stopping the left one a bit earlier - but I guess...