Michael Hoffmann

Results 224 comments of Michael Hoffmann

Shouldnt compaction be turned off if you ship blocks?

As the bot mentioned, can you try `--block-discovery-strategy=recursive` ?

Deduplicating time series data is surprisingly hard! I have no great idea how to do it properly. The approach that Thanos takes during query time is roughly that we start...

Yeah I'm happy to brainstorm about this if you have an idea!

Penalty is the same algorithm that the querier uses though.

> @MichaHoffmann Wouldn't putting a configurable upper bound on the penalty solve this issue (or at least allow fixing it by configuration)? In the sense that we always switch replica...

> How does this work with the new engine? @MichaHoffmann @fpetkovski Does the new engine support those experimental functions Not yet but at least those sorting functions should be very...

FWIW: i think minio-go already transparently retries without the client having much control over it: https://github.com/thanos-io/promql-engine/pull/477/files. But ultimately it feels like retrying should be a decision that the bucket client...

> [@GiedriusS](https://github.com/GiedriusS) (regarding `FuzzNodesMarshalJSON` test fail..) > > The problem might be with `promqlsmith` about how its generating queries based on seed values. Sometimes, the test passes but in certain...