objstore icon indicating copy to clipboard operation
objstore copied to clipboard
verified publisher icon thanos-io

Add support for WriterTo in TimingReader

Open fpetkovski opened this issue 1 year ago • 1 comments

This commit adds support for the WriterTo interface in the TimingReader so that it can be used efficiently in io.Copy.

  • [ ] I added CHANGELOG entry for this change.
  • [ ] Change is not relevant to the end user.

Changes

Verification

fpetkovski avatar Jun 11 '24 06:06 fpetkovski

If r implements Seeker then we wont ever return a writerTo, right? Is that problematic?

MichaHoffmann avatar Jun 17 '24 16:06 MichaHoffmann

We merge this for now and we can add all combinations later. I don't see problems when querying a Google Storage bucket.

fpetkovski avatar Sep 07 '24 11:09 fpetkovski