Larry Ruane
Larry Ruane
Although the suggested change is okay, my experiments show this is not a problem. The Golang `regexp` documentation is here: https://github.com/google/re2/wiki/Syntax. I wrote a small test program to try to...
@defuse, sorry, I forgot about this. Do you still think it's worth doing? If so, you could reopen it and I could quickly merge it.
For anyone wanting to review this PR and would like some help with basic mempool concepts, I made a video: https://youtu.be/sQ05azzTp9o -- it mentions 26152 but I think would be...
Just FYI, I was unable to reproduce the problem with `bitcoin-cli -signet verifychain 4 1000`. However, it did reproduce when I increased the number of blocks to 5000. I'll review...
For anyone wanting to review this PR and would like some help with basic mempool concepts, I made a video: https://youtu.be/sQ05azzTp9o.
re-ACK, although now rebase is needed
ACK 93c70287a6434c6c665a211dc4dfbbd9c3db4083
@MarcoFalke @glozow I've written some unit tests, will push to a branch and suggest it here.
In case anyone's wondering about the practical effect of this patch _today_ (obviously, it could be very different in the future), here are some recent transactions that this patch would...
Force-pushed to incorporate two review suggestions (thanks!): - add description to the other README files (benchmark, fuzz, qt) - rename `TEST_BITCOIN_PATH` to `BITCOIN_TEST_PATH`