Larry Ruane
Larry Ruane
Converted to Draft because a good solution is going to require careful examination of upstream Bitcoin Core.
Many logging calls (calls to `LogPrint()` and `LogPrintf()`) have many arguments, for example https://github.com/zcash/zcash/blob/488067613c0746fc5f79473585041fdf225817f8/src/transaction_builder.cpp#L681 The format strings of these calls must match the arguments in number and type, a source...
The commit that deals with the undo files (`datadir/blocks/revnnnnn.dat`), 04a48f9269e75bc1a9dc5f0927dd8cf12be08ddf, has a couple of problems. The first is that the checksum verification in `UndoReadFromDisk()` fails. I started `zcashd` on my...
An update on my suggestion, I used `hexdump` to verify that the undo files contain the expected bytes (the version byte and the zero fake-tze vector count). Also, in case...
> [6d75df7](https://github.com/bitcoin/bitcoin/commit/6d75df749d4aa9f2479fbe9d1551c8a5c1a3607f) to [c348172](https://github.com/bitcoin/bitcoin/commit/c34817279cca646be09d6210d2a7b3dd45b03fe0): Rebased and made the approach analogous to the one by @dhruv in [#24545](https://github.com/bitcoin/bitcoin/pull/24545/commits/36bb7117a45ee2e0c411ab1152b818e0acfa0c5c) by renaming `AddedNodeEntry` to `AddedNodeParams` and and making it a member of `AddedNodeInfo`....
Should this have release notes?
@rserranon > I couldn't make this work on signet: `./contrib/signet/getcoins.py -c $BINARY_PATH/bitcoin-cli -a myHeFvPiKR39FpXfzztENQekHdUoFKordv bitcoin_cli_args signet datadir="/tmp/24-rc-test"` What worked for me looks slightly different from what you did (note I...
Daira, what would be the right way to fix this? Implement our own super-simple versions of these functions, so that the behaviour is obvious and well-defined (even if less feature-rich)?...
ACK d87cb99bb37637e26a9e00b9f7de4bc6f44cb79d
This will be fixed by https://github.com/zcash-hackworks/lightwalletd/pull/149 (sorry it did not get its own PR over in that repo). @pacu, if it is possible and convenient for you to test that...