Larry Ruane
Larry Ruane
Force pushed the changes described above (https://github.com/bitcoin/bitcoin/pull/26564#discussion_r1428581458( but I don't understand why CI is failing. All the failures are that `LockDirectory()` is not found, but it's declared in `util/fs_helpers.h` and...
Yes, that's what the compiler error says, but that function doesn't seem to be in that namespace. Its other callers don't qualify it, and if I do qualify it, the...
Force pushed twice to rebase and fix the CI problem, ready for review, thanks, @furszy!
> may be an issue with some tests when `testdatadir` is provided a relative path I can't reproduce this problem. I tried both running the one test alone and running...
>This contradicts the PR summary: Thanks for the review! You're right, good catch. I updated the PR description. The behavior is correct, we don't want to remove the `.lock` file...
@tdb3 - Ah, I bet the problem relates to `BDB`. I don't build that way. I don't know what's wrong, but just to verify one thing, the [build document](https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md#berkeley-db) says:...
@tdb3 >Hmm. BDB_PREFIX was an absolute path Draht, I'll set up BDB on my system here and see if it reproduces. If not too much trouble and if you have...
@tdb3 I force-pushed a fix, it turns out that Berkeley DB (BDB) doesn't work with a relative path, only absolute. So it's a one-line fix. Thanks for finding this bug!
Force pushed to add release note (not sure if this is important enough to have a release note for, but just in case), and also updated the `help help` text...
> Concept NACK on the top commit: having each one in a separate file is nice. I can remove it, but may I ask why, I assume that the purpose...