Larry Ruane

Results 51 issues of Larry Ruane

### Background During the first part of reindexing, `LoadExternalBlockFile()` sequentially reads raw blocks from the `blocks/blk00nnn.dat` files (rather than receiving them from peers, as with initial block download) and eventually...

Validation
Resource usage

I copied most of the following from slack: I started `zcashd` that I built at master branch commit 3213527141782a9a4e018e00d34de16889a128f0, which is about a week newer than v5.1.0, and a soon...

C-bug
A-wallet

Stopping `zcashd` while it is loading the block index during startup has no effect until the entire index is loaded, which can take several minutes. This PR fixes that. Note...

I-performance
C-upstream-port

Addresses #2075, do not use `atoi` and variants because they have undefined behavior for some inputs. Includes changes from upstream: - bitcoin/bitcoin#13603 - bitcoin/bitcoin#8164

C-bug
I-SECURITY
spring_cleaning
PR_cleanup
Death By A Thousand Cuts

A-testing
A-logging

Improve listnotes.py test for coverage and clarity, also cleanup corresponding wallet rpc code. Closes #3553.

These are locking changes from upstream (bitcoin core) release 0.17 (Feb 16, 2018 to Aug 13, 2018), oldest to newest (when merged to the master branch). This PR is complete...

C-upstream-port
I-race

These are locking changes from upstream (bitcoin core) release 0.19 (Mar 3, 2019, to Oct 2, 2019), oldest to newest (when merged to the master branch). More commits will be...

C-upstream-port
I-race

These are locking changes from upstream (bitcoin core) release 0.18 (Aug 13, 2018, to Mar 3, 2019), oldest to newest (when merged to the master branch). UPDATE 2021-May-4: This PR...

C-upstream-port
I-race

This backward-compatible change would help with code review, testing, and debugging. When `test_bitcoin` runs, it creates a working or data directory within `/tmp/test_common_Bitcoin\ Core/`, named as a long random (hex)...

Tests