Larry Ruane

Results 228 comments of Larry Ruane

Force-pushed to resolve hidden conflict, and make the functional test less brittle (not rely on hardcoded constants).

Force-pushed rebase due to conflict with #25571

@stickies-v, thanks for the review, I decided to force-push all your suggestions. This force-push also includes a small refactor (adds the `FillBufferUpToLength()` to eliminate some duplicated code). Just to make...

Force-pushed again to fix (I hope) CI failure (ARM (32-bit), where `size_t` is 32 bits instead of 64).

Force-pushed for review suggestions, thanks!

Force-pushed to fix CI failures

Force-pushed to address review comments (thank you, @stickies-v), ready for review.

ACK 25d734e88b75b7944972254ed490cc6aac3b5901 I didn't actually understand the entire article (the math is somewhat complex for me), but it looks like a good resource. I have a suggestion for the article;...

> > But after syncing, the private balance is way off, > > @LarryRuane these new coins it says you have, are they / were they spendable? No, definitely not.

Note that https://github.com/bitcoin/bitcoin/pull/15932 is not a locking _fix_, but it is locking-related. It's a performance improvement that comes from reducing the scope of `cs_main`, which is a highly-contended lock. I...