Larry Ruane

@mms710, yes, I made Eirik's requested changes in the most recent force-push. I just marked his comment as "resolved" (having neglected to do that earlier). I just rebased (and force-pushed)....

A couple of days ago, Aditya ([Zecwallet](https://www.zecwallet.co/) developer) also asked for this change. Note that this restriction is not enforced by the consensus rules (you can create a raw transaction...

Rebased on master, now that this PR is next in line. This is ready for review and possibly merging.

Thanks, @str4d, I think I've resolved all your comments. Regarding https://github.com/zcash/zcash/pull/5034#discussion_r640065264, I went ahead and added https://github.com/bitcoin/bitcoin/commit/fb8fad1586ced69fa37c665a11916ae4c4d0df05 to the set.

Have you looked at how Bitcoin Core solved this problem? See `ArgsManager::FlagsOfKnownArg()` (https://github.com/bitcoin/bitcoin/blob/d8a66626d63135fd245d5afc524b88b9a94d208b/src/util/system.cpp#L358). This approach addresses @daira's concern. Cherry-picking all of their argument processing would create significant benefits but a...

Running commit 1e6f4608b4754dd37510ef08c27cd0f4de2e0f8a (tip of `master` on June 10) I hit this on testnet. I ran this same binary on mainnet and it didn't occur there. I don't _think_ my...

In zcash/zcash#2075 Daira mentioned `locale` may be a problem. This PR does not address that. I don't *think* there is a problem there, or much of a problem. I think...

just FYI, I rebased with latest master, the full test suite passes.

Upstream interrupts the block index loading in the same way: https://github.com/bitcoin/bitcoin/blob/c2d8ba6265a4375b039daf9cb36c0e0edad57eef/src/txdb.cpp#L254 Note similar #4535 but that problem does not reproduce for me (ctrl-c works during reindexing).

I accidentally closed this. Addressed @daira's review comment.