Larry Ruane
Larry Ruane
@luke-jr > This combination seems dangerous... :/ If the concern is that someone may specify a real data directory by mistake, that's a good point! A real datadir has a...
> Not quite, I'm more concerned about a situation where `BITCOIN_TEST_PATH` might be `/home/user` or something else weird. While it's a crazy user error, nobody expects setting an env variable...
Yes, still hoping to get this merged. Force-pushed 5df0ed5ab789e005cb9aa0fc3ab61b7ce0b80ec8 to rebase onto the latest master (since it's been a long time)
Another force push to improve the doc slightly and to address review comments, thanks @kouloumos! Ready for review, also ping @theStack.
Rebased for merge conflict.
Added commit ed37d296ba0a17daaf3334a011398ce05b30d69c to implement review suggestion https://github.com/bitcoin/bitcoin/pull/26564#discussion_r1408489618, thank you, @furszy!
Pushed a4bd4c490c140b7f59dc98664f1a0996087cf43d to fix merge conflict, and 567ce8bfecfc674b8f68613bfdfe6ddd55310769 to fix Windows CI failure (I think the problem was that we were trying to remove the data directory while still holding...
Thanks, @furszy, I reworked your commit a bit, that was a big help! It did mean dropping support for `fuzz`, `bench_bitcoin`, and `test_bitcoin-qt` but this change really only benefits `test_bitcoin`...
Force pushed to remove the fix to `doc/benchmarking.md` as suggested by https://github.com/bitcoin/bitcoin/pull/26564#discussion_r1420176846
Force pushed suggestion by @furszy (thanks!) https://github.com/bitcoin/bitcoin/pull/26564#discussion_r1424023270