Larry Ruane

Results 228 comments of Larry Ruane

> I dont think this is needed I agree this is not needed, but does every change have to be "needed"? Can't it just be an improvement? This would be...

> Is there a better UX option here? What about `bitcoin-cli helpdetail`? I agree your suggestion would be better, or maybe even `bitcoin-cli -helpdetail` (with a dash) because as it...

@luke-jr I don't understand who would be doing a diff or why, but that's okay, I force-push-removed that commit. Probably better to minimize the patch anyway. Thanks!

@epiccurious > What about `bitcoin-cli helpdetail`? Force-pushed your suggestion, thanks again, I like that much better. Aside: I had mentioned as a possibility: `bitcoin-cli -helpdetail` (with the dash), but that's...

Force-pushed to fix CI failures. @luke-jr can you please remove your NACK now that I've deleted the test commit you disapproved of? Thanks.

Force pushed to rebase to latest master. @luke-jr, @epiccurious, can you review? Thanks.

That doesn't quite work for me, but this does (using Ubuntu, maybe it depends on the OS): ``` bitcoin-cli help | grep -o '^[a-z]*' | xargs -I {} bitcoin-cli help...

Force pushed from becf38061b2625bcc629293fec0dce7c27292e14 to - efc2e70f1763c6bf3f6b246202adb9d5f1f798ee [diff](https://github.com/bitcoin/bitcoin/compare/becf38061b2625bcc629293fec0dce7c27292e14..efc2e70f1763c6bf3f6b246202adb9d5f1f798ee) -- needed rebase - 16d2903b8a9e6e980e24e04ab2d86c7e778f5764 [diff](https://github.com/bitcoin/bitcoin/compare/efc2e70f1763c6bf3f6b246202adb9d5f1f798ee..16d2903b8a9e6e980e24e04ab2d86c7e778f5764) -- make the suggested review changes - 2e80e3bdcd9cac7878c0d14956ba9c57626da855 [diff](https://github.com/bitcoin/bitcoin/compare/16d2903b8a9e6e980e24e04ab2d86c7e778f5764..2e80e3bdcd9cac7878c0d14956ba9c57626da855) -- fix CI failure - 6c564aafb3d5f61fffa0d6311ad688c47b14014a [diff](https://github.com/bitcoin/bitcoin/compare/2e80e3bdcd9cac7878c0d14956ba9c57626da855..6c564aafb3d5f61fffa0d6311ad688c47b14014a)...

Force-pushed to implement review suggestion to use `TicksSinceEpoch()` (thanks!)