klipper icon indicating copy to clipboard operation
klipper copied to clipboard

Config_Reference.md - QGL change

Open JamesH1978 opened this issue 8 months ago • 5 comments

It has been mentioned that the offsets have no bearing on the points probed in quad gantry level, cited by user bjkroll on discord, both on beacon using its module and using the standard probe module with tap. For maximum accuracy, ensure your probe offsets are configured. seems to be extraneous and misleading.

Thanks James

Signed-off-by: James Hartley [email protected]

JamesH1978 avatar Apr 16 '25 14:04 JamesH1978

FYI, the probe offsets are used in the calculations for z_tilt and quad_gantry_level. So, it is important that the user specify these values correctly.

We can certainly change the documentation if it is confusing though.

-Kevin

KevinOConnor avatar Apr 16 '25 18:04 KevinOConnor

So the offsets are used to track back the nozzle position from the set points, which are manual absolute position for the probe over the point to give the actual nozzle absolute position for calcs? I think that makes sense... If so, then yes it may want to clarify rather than remove completely

Thanks James

JamesH1978 avatar Apr 16 '25 20:04 JamesH1978

Right - the probe offsets are used when calculating the toolhead position relative to the configured gantry positions.

-Kevin

KevinOConnor avatar Apr 17 '25 01:04 KevinOConnor

Good to know the calculations are still good. Would it be clearer in the documentation to note these probe points as the nozzle position, and not the probe itself?

bjkroll avatar Apr 17 '25 14:04 bjkroll

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

github-actions[bot] avatar May 02 '25 00:05 github-actions[bot]