klipper icon indicating copy to clipboard operation
klipper copied to clipboard

Klipper lib CMSIS: bump version to 6.1.0

Open bevanweiss opened this issue 1 year ago • 2 comments

Update CMSIS to v6.1.0.

Tested with STM32F103 build.

bevanweiss avatar Aug 30 '24 06:08 bevanweiss

I'm a big fan of updates, so 👍

Would you anyway please elaborate if this solves any real world issues, performance increases, better compatibility to existing hardware, etc?

Sineos avatar Aug 30 '24 08:08 Sineos

I'm a big fan of updates, so 👍

Would you anyway please elaborate if this solves any real world issues, performance increases, better compatibility to existing hardware, etc?

I do wish I could state great benefits. But there's really no 'improvements' in just the header version updates here. The only argument for the updates is that it keeps things up to date with upstream code. Vendor headers will also be targeting these newer versions of the ARM CMSIS headers.

'small' updates like these tend to be a bit nicer than trying to jump multiple major versions later on too :)

https://community.arm.com/arm-community-blogs/b/tools-software-ides-blog/posts/cmsis-v6-is-here

bevanweiss avatar Aug 30 '24 09:08 bevanweiss

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

github-actions[bot] avatar Sep 13 '24 12:09 github-actions[bot]

We can certainly update these files, but I think we should have a use-case for it first. That is, if we're adding some new chip that needs the later version then I think it's fine to update as part of that work. I'm leery of making changes that could introduce a regression without some benefit to taking that risk.

Thanks, -Kevin

KevinOConnor avatar Sep 17 '24 15:09 KevinOConnor