KevinOConnor

Interesting, thanks. I'm curious what your long-term plans are for this work. Are you still working on it? Are there users utilizing this system today? I didn't see your questions...

Thanks. As high-level feedback, this sounds like useful functionality. I have some comments and questions: 1. I'm confused why this new module ties into the temperature system (and is described...

I should also note that most temperature sensors in Klipper today are implemented with mcu code that can check the min/max temperature setting and directly invoke a shutdown if the...

> I have one definition for the chip in general that controls stuff like the i2c definition and then there is a separate definition for temperature sensors where the sensor_pin...

Also, as recently discussed in #6553, src/thermocouple.c and klippy/extras/spi_temperature.py could also be looked at as an example - though as mentioned there it may not be the best example. -Kevin

I'm not sure I understand. To take a step back, on one of my printers, I have the following: ``` [heater_bed] heater_pin: PC9 sensor_type: NTC 100K MGB18-104F39050L32 sensor_pin: PC4 control:...

Ah, the simple way to handle that is to not implement `voltage_offset` nor `adc_voltage` in ads1x1x.py . The existing thermistor (and adc_temperature) code already handles all that logic. So, something...

Thanks. This change looks odd to me as the purpose of the error is to warn users that Klipper's internal calculations do not support movement during the macros. It's not...

Thanks. Good catch. I implemented a slightly different fix (commit d8d072b3). -Kevin

Thanks. I have a few high-level comments: 1. I can see where it would be useful to gather this information, and it seems like a useful feature. 2. I think...