KevinOConnor

Results 442 comments of KevinOConnor

pid improvements

> I'm working on the documentation now, is there a place you want me to put the spreadsheet i created? Alas, I'm not sure what I'm looking at with that...

pid improvements

> its going to take me a little while on the documentation Thanks for the update. I too am struggling with time constraints. Please do not feel the need to...

Added printer config for SUNLU T3

Thanks. -Kevin

Support for mixing extruders

Thanks. At a high-level, the changes seems okay to me. I do have some comments though: 1. The number of new commands need to be reduced. Perhaps just two commands...

Support for mixing extruders

Unfortunately, it's primarily due to lack of time on my side. I'll assign this to myself to turn off the bot. -Kevin

Add support for thermal protection without temperature delta

Thanks, but I don't think this is a good fit for the main Klipper branch. This code adds complexity to the verify_heater code, and it's not clear to me that...

TMC: CoolStep support

Thanks! Happy to merge. Alas, github wont let me merge directly. You can try a `git rebase` (which would then preserve the github history that this PR was merged), or...

TMC: CoolStep support

Thanks. I committed this change, along with a minor wording change to the docs (commit e0cbd7b5). -Kevin

temperature_driver: adds driver temperature sensor

Thanks. As high-level feedback, I'm leery of introducing a "dummy temperature" to indicate "the temperature is not known". That is, I'm leery of using 0.0 when the driver temperature is...

heater_fan: added hysteresis

Thanks. As high-level feedback, I think it is fine to add hysteresis support to heater_fan. However, I'm not sure it is worthwhile to add a new config setting for it,...