Jianjun Hu
Jianjun Hu
@mwetter It will be ready for your review when CI tests are passed.
@mwetter I have addressed your comments. It will be ready for your review when the CI tests passed.
@mwetter it's ready for you review.
@khinkelman Please see the inline comments. I have also committed some changes [aada46d](https://github.com/lbl-srg/modelica-buildings/pull/3093/commits/aada46d5433c329b27b054d7015f4bdb3ff1f4fa), [9bd530d](https://github.com/lbl-srg/modelica-buildings/pull/3093/commits/9bd530d7be8f680b8097985229b0df9d9cc4554b), [4a87098](https://github.com/lbl-srg/modelica-buildings/pull/3093/commits/4a8709843697bef604e6d901c94dfd575e24345a), [551c8a3](https://github.com/lbl-srg/modelica-buildings/pull/3093/commits/551c8a3cc69a6c5eb5d4c68ce26a974f2601438e), to clean up models and reference results. The model `Buildings.Experimental.DHC.Examples.Cooling.DirectUncontrolledETS` failed to run with...
@khinkelman I rerun the unit test for the models in package `Buildings.Experimental.DHC.Plants.Cooling.Examples` and added the `Buildings.Experimental.DHC.Examples.Cooling.DirectUncontrolledETS` to the exclusion list to not run the model with `OpenModelica`. I have no...
@SenHuang19 See below: - [ ] run `../bin/verifyFiles.py`, there are following errors: ``` *** Error: File 'Controls/OBC/CDL/Continuous/Validation/PID.mo' contains invalid string 'Algorithm='. *** Error: File 'Controls/OBC/CDL/Continuous/Validation/PID.mo' contains invalid string '__Dymola_Algorithm'. ***...
@SenHuang19 - [ ] in `Buildings.Controls.OBC.CDL.Continuous.Validation.PID`, it should not have `__Dymola_Algorithm="Cvode"` - [ ] remove the .mos file `Resources/Scripts/Dymola/Controls/OBC/Utilities/PIDWithAutotuning/Validation/PIDWithAutotuningAmigoFOTD.mos` and `Resources/Scripts/Dymola/Controls/OBC/Utilities/PIDWithAutotuning/Validation/PIWithAutotuningAmigoFOTD.mos` - [ ] remove `Resources/Scripts/OpenModelica/compareVars/Buildings.Controls.OBC.Utilities.PIDWithAutotuning.Validation.PIWithAutotuningAmigoFOTD.mos` - [ ] remove...
@AntoineGautier Please see the latest models after commit [254a9f5](https://github.com/lbl-srg/modelica-buildings/commit/254a9f5353132d3ec69e72a04b6dbf3e703375a9). The typos have been corrected.
> Here are my last comments on [254a9f5](https://github.com/lbl-srg/modelica-buildings/commit/254a9f5353132d3ec69e72a04b6dbf3e703375a9). This is in good shape. > > In `Buildings/Controls/OBC/ASHRAE/G36/AHUs/MultiZone/VAV/Controller.mo` > > ``` > Buildings.Controls.OBC.CDL.Interfaces.BooleanInput u1MinOutAirDam > if buiPreCon == Buildings.Controls.OBC.ASHRAE.G36.Types.BuildingPressureControlTypes.ReturnFanDp > "Minimum...
@AntoineGautier Addressed your comments in commit b9e34aa.