Jianjun Hu

Results 138 comments of Jianjun Hu

@karthikeyad-pnnl Please see inline comments.

@karthikeyad-pnnl Run following gives error: ``` jianjunhu@ubuntu:~/GitFolder/modelica-buildings/Buildings/Resources/Data/Fluid/Humidifiers/DXDehumidifier$ sh run.sh ./DXDehumidifier.idf EnergyPlus Starting EnergyPlus, Version 23.2.0-7636e6b3e9, YMD=2023.12.13 14:36 **FATAL:Errors occurred on processing input file. Preceding condition(s) cause termination. EnergyPlus Run Time=00hr...

@karthikeyad-pnnl Please rebased the PR to the development branch `issue3544_HeatPumpRTUControls`.

@karthikeyad-pnnl For the class `Buildings.Controls.OBC.RooftopUnits.AuxiliaryCoil.AuxiliaryCoil`, the documentation shows that `"It then utilizes the heating coil valve position signal uHeaCoi as an auxiliary heating coil operation signal yAuxHea if uHeaCoi exceeds...

@karthikeyad-pnnl Thanks. Then please update the documentation to avoid the misunderstanding.

@karthikeyad-pnnl Could you please update the documentation, then we can review and see if it can be merged?

@karthikeyad-pnnl Would you please check if there are anything more should be changed?

@mwetter It's ready for your review after the CI tests passed.

@karthikeyad-pnnl Would you please address Michael's inline comments?

@SenHuang19 Please see branch `issue3618_airFilter` for the development.