Jianjun Hu

Results 138 comments of Jianjun Hu

@SenHuang19 All the new validation models are failed to run by Optimica. ``` (py395) jianjunhu@ubuntu:~/GitFolder/SenHuang19/modelica-buildings/Buildings$ ../bin/runUnitTests.py -s Buildings.Fluid.Dehumidifiers -t optimica Regression tests are only run for the following package: Buildings.Fluid.Dehumidifiers...

@SenHuang19 Just double checked. The error is due to the OS environment setup. After correcting the setup, it can run with Optimica.

@SenHuang19 Let me when it is ready for another review.

@AntoineGautier I think the simplified `Latch` implementation `LatchSignal` can replace the current implementation. It indeed has the same results.

@mwetter It's ready for your review.

@SenHuang19 Please see comments below: - [ ] add detailed description to the validation model, please see in the model `Buildings.Controls.OBC.Utilities.Validation.PIDWithInputGains` for the reference of how to describe the validation....

@khinkelman I just created a development branch [issue3512_improveDocu_Steam](https://github.com/lbl-srg/modelica-buildings/tree/issue3512_improveDocu_Steam) for the change.

@karthikeyad-pnnl @terrancelu92 We are seeing following warning: ``` 12960000.000 DXDehumidifier.building: Warning from EnergyPlus: Version: in IDF="23.1" not the same as expected="9.6" 12960000.000 DXDehumidifier.building: Warning from EnergyPlus: Version: in IDF="23.1" not...

@karthikeyad-pnnl Did you have a chance to downgrade the IDF file?

@mwetter It will be ready for your review when the tests passed.