Jianjun Hu
Jianjun Hu
@caryfaulkner @mwetter The ISAT model failed to run with Optimica as shown in the [CI test](https://app.travis-ci.com/github/lbl-srg/modelica-buildings/jobs/527005856#L649). It seems to be the same reason as shown in issue #2231 for the...
@caryfaulkner Would you please take another look to verify if the changes are intended, as it has been a while since our actively working on it last time?
@mwetter It's ready for your review.
@caryfaulkner Would you please address Michael's inline comments?
@karthikeyad-pnnl - [ ] In `FanCoilUnit.Controller`, the following connectors rename and the comments should be passed to the subsequences - change the output connector `yFan` to `y1Fan` and change the...
@SenHuang19 In the composed block `Buildings.Controls.OBC.Utilities.PIDWithAutotuning.FirstOrderAMIGO`, there is no detailed documentation of how to use the controller. For instance, by only looking into the model, the user will not know...
@mwetter It will be ready for your review when CI tests passed.
@SenHuang19 I see the CI tests are failing. I can fix some of them and will let you know if there is any help from you.
@SenHuang19 I did some editing on the documentation and comments. However, I have some additional comments: - [ ] For the class `Buildings.Controls.OBC.Utilities.PIDWithAutotuning.Relay.BaseClasses.Validation.HalfPeriodRatio`, - the documentation indicates that at 0.1...
@mwetter It will be ready for your review when the tests are passed.