Jianjun Hu
Jianjun Hu
@mwetter It's ready for your review.
The results difference between OpenModelica and Dymola is due to the results different of `PIDWitTun.resPro.TunMon.tInc.us`. See the one from OpenModelica:  And from Dymola: 
The root cause of the OpenModelica and Dymola results difference is from the instance `PIDWitTun.resPro.TunMon.gretOnAndtOff`. See the OpenModelica results:   And the Dymola results:  In both simulation, the...
@mwetter I will submit a bug report to OpenModelica.
There was two discussion about the OpenModelica issue, in their ticket [8600](https://github.com/OpenModelica/OpenModelica/discussions/8600) and [11049](https://github.com/OpenModelica/OpenModelica/issues/11049), and the issue we created [11468](https://github.com/OpenModelica/OpenModelica/issues/11468#issuecomment-1785664197). The comparison between two real variables would cause results difference...
@mwetter I further improved the real comparison in the class `Relay.BaseClasses.TuningMonitor`, now we can only see the results difference during the initialization.
Close this PR as there will be a new PR that introduces an upgraded implementation.
@AntoineGautier Thanks for the comments. I am going through your comments and will address them. It will be really appreciated if you keep reviewing it.
@caryfaulkner Hello Cary, did you have a chance to push your local files to your repo? I tried to run the models from the one in your local repo, but...
@caryfaulkner Did you have a chance to clean up the code? Thanks!