Jianjun Hu

Results 138 comments of Jianjun Hu

@mwetter It's ready for your review.

The results difference between OpenModelica and Dymola is due to the results different of `PIDWitTun.resPro.TunMon.tInc.us`. See the one from OpenModelica: ![re](https://github.com/lbl-srg/modelica-buildings/assets/23491921/d1501236-eae2-45e4-89fb-702e30c6592c) And from Dymola: ![re](https://github.com/lbl-srg/modelica-buildings/assets/23491921/07d1386e-8d71-4d55-bf82-48828d279542)

The root cause of the OpenModelica and Dymola results difference is from the instance `PIDWitTun.resPro.TunMon.gretOnAndtOff`. See the OpenModelica results: ![Omc-1](https://github.com/lbl-srg/modelica-buildings/assets/23491921/b4c1e2fc-02d6-4220-918b-88752f890f1a) ![Omc-2](https://github.com/lbl-srg/modelica-buildings/assets/23491921/5bb5d106-b5ac-4116-b245-3461d3dba615) And the Dymola results: ![dymola](https://github.com/lbl-srg/modelica-buildings/assets/23491921/5b9fe34c-5b74-4671-a035-b2ecedc1ac5b) In both simulation, the...

@mwetter I will submit a bug report to OpenModelica.

There was two discussion about the OpenModelica issue, in their ticket [8600](https://github.com/OpenModelica/OpenModelica/discussions/8600) and [11049](https://github.com/OpenModelica/OpenModelica/issues/11049), and the issue we created [11468](https://github.com/OpenModelica/OpenModelica/issues/11468#issuecomment-1785664197). The comparison between two real variables would cause results difference...

@mwetter I further improved the real comparison in the class `Relay.BaseClasses.TuningMonitor`, now we can only see the results difference during the initialization.

Close this PR as there will be a new PR that introduces an upgraded implementation.

@AntoineGautier Thanks for the comments. I am going through your comments and will address them. It will be really appreciated if you keep reviewing it.

@caryfaulkner Hello Cary, did you have a chance to push your local files to your repo? I tried to run the models from the one in your local repo, but...

@caryfaulkner Did you have a chance to clean up the code? Thanks!