Jianjun Hu

Results 139 comments of Jianjun Hu

@karthikeyad-pnnl - [ ] In `BoilerPlant.Pumps.PrimaryPumps.Controller,missing`, it is missing`` after [line 1249](https://github.com/karthikeyad-pnnl/modelica-buildings/blob/52f2f672755799c80e95999451f3791537025b3b/Buildings/Controls/OBC/ASHRAE/PrimarySystem/BoilerPlant/Pumps/PrimaryPumps/Controller.mo#L1249) to close the `` in line 1235. - [ ] In `BoilerPlant.Pumps.SecondaryPumps.Controller`, it is missing `` after [line...

@karthikeyad-pnnl I just created the development branch `issue3327_SPAWN_PTHdevelopment` on our repo. You may re-base the branch now.

The change looks good to me. This in fact may also address issue #3841, which would relate to the block `TrueFalseHold`. We would need to conditionally remove the corresponding state...

@AntoineGautier Thanks for the detailed information. For the `latch` block, keep `elsewhen {clr,u}` rather than `elsewhen{change(clr),u}`. For the `TrueFalseHold`, I am actually updating the block as suggested: conditional remove the...

@karthikeyad-pnnl See below comments: 1. Avoid using the temperature sensor to measure the instrem fluid temperature as it will introduce additional states, as below the instance `senTem`, `senTemWetBul`: ![Direct](https://github.com/user-attachments/assets/0f0e9d54-ea9d-4495-9a2e-4be41b62dbec) You...

@milicag which branch is it in modelica-buildings repo? I can do the test as well.

In the section `7.5 Elementary block`: - [ ] Every block should have the icon. - [ ] The icons' color are not consistent. Block like `Add` exists in both...

@mwetter I have updated the `post_process.ipynb` based on the latest update from yesterday (branch `issue24_plot_IHG`). It is fine to generate plot showing room temperature of south and north zone for...

@milicag when running outside of the notebook, it can successfully run first annual case but not the second one. ``` Read annual G36 without diverse loads Traceback (most recent call...

@milicag I checked the Ubuntu system memory usage when running the code. It indicates that the memory easily use out, reduced from 12GB to less than 1GB and then becomes...