(Jip) Willem Wijnia
(Jip) Willem Wijnia
Yes, but then less excessive. I may do a small setup this month, and then we can investigate whether that is the direction we'd like to take.
> Maybe unit icons could be grabbed from the generated github wiki, with unit ids or enhancement icon IDs as references in the snippet. In my point of view, unit...
@MrRowey I think it is best to first have a wider discussion about this before we continue further. On a different note: I do like how you used the snippet...
That is an interesting alternative solution, very creative 😃 . I'll need to toy around with it to see the impact.
If it is up to me then we're not turning every Stinger into a mobile factory. Mobile factories are difficult to maintain, they are relatively expensive on the simulation let...
Related to https://github.com/FAForever/fa/pull/6345
Is this related to https://github.com/FAForever/fa/issues/6314 ?
I do not fully understand the context of the change. Wouldn't it be better in general to simplify the check to just verifying that it is a valid player slot?...
@maudlin27 can you format the snippet by starting it with `- (#6369)`? We'll soon document that properly 😃 , after that you have my approval
> Formatting the snippet is a minor change I think we can do ourselves as repository maintainers @Garanas. I do not agree. You're right that this is a trivial change...