(Jip) Willem Wijnia
(Jip) Willem Wijnia
> the shield bounce does not look right. There seems to be a small delay before the bombers bounce back. Yes, there's a single tick where it hiccups at the...
I'm not sure. If it is trivial to reproduce then yes, but for rare edge cases I don't think we should keep increasing the size of the collision boxes. The...
I don't fully understand why this pull request is required.  In this scenario the upgrading mass extractor is skipped just fine. In what scenario does it end up selecting...
I'm fairly certain that this was related to: - https://github.com/FAForever/fa/pull/4338 And that is fixed now.
@Hdt80bro I'll close this pull request tomorrow. Time caught up and this pull request feels dated at this point
The use of `GetEntityById` and `GetUnitById` appears to be fast - I can do 900 queries in 0.4ms. That's sufficient for this type of task!
@clyfordv can you write a changelog snippet? Make sure to also describe the practical change for the players
> Dropping the VetInstigators table introduces the issue where a new unit with a reused ID might get credit for kills by the previous (now dead) unit that had the...
But is there a way to test and see how often it happens? What if we re-introduce the backup table and see how often they're not the same unit for...
Okay; that is super interesting. Let's let this sink in and see if we can come up with a solution.