(Jip) Willem Wijnia

Results 464 comments of (Jip) Willem Wijnia

Reverting pull requests is best done with the revert option if that is available, see also: ![image](https://github.com/FAForever/fa/assets/15778155/1224aafb-ebda-4c9a-87dc-fa0b6a53b943) It would be a separate pull request. Relevant pull request to revert: https://github.com/FAForever/fa/pull/6253

@lL1l1 / @Tagada14 processed the feedback

Are you referring to this blueprint value: https://github.com/FAForever/fa/pull/6279

> > Are you referring to this blueprint value: #6279 > > The UnitWeight stat is now populated via blueprints-units.lua. We could also populate the field in the blueprints themselves...

This also happens when it is toggled and you start an upgrade.

Counting the props is do-able, but is the generator able to retrieve the reclaim value from the blueprint files?

I'm open to suggestions on the name of the feature in the game options 😃 !

Example of dynamic scaling: https://github.com/FAForever/fa/assets/15778155/48d6bfe1-6730-4d3a-b6ff-c18d0138109c

> `otherBp` in `OnDetectAdjacencyBonus(userUnit, otherBp)` seems to contain the bp of the adjacent build preview, even for templates. This allows checking for adjacency bonuses. You're right! I just checked again,...

@lL1l1 I've prepared the functions to allow them to be expanded in the (near) future. Could you give the pull request a review as it is right now? Then we...