Prevent TML from overflying TMD when the target is at a higher altitude
See discussion here: https://forum.faforever.com/topic/7834/tml-height-needs-to-be-lowered/9
Overview Fix to prevent TML from (more easily) overflying TMD when shooting at targets at higher elevation. Previously the height of the target was used to calculate the highest point of the arc; this uses the height of the launcher instead. Note that with this fix (and, implicitly, prior to the original projectile rework) it's still possible for missiles to overfly nearby TMD, but this narrows the window.
Possible Issues The original intention behind using the height of the target was to eliminate an edge case where the target is so high that the missile doesn't arc properly. This reintroduces that (exceedingly rare--missiles fly very high relative to the terrain) possibility.
Is this related to https://github.com/FAForever/fa/issues/6314 ?
Closing since it doesn't solve the original issue.
This doesn't fix UEF TML flying so high that zapper's beam doesn't reach them on the first shot:
How did you make it fly so high? I cannot reproduce this.
How did you make it fly so high? I cannot reproduce this.
That height is the middle of the max range arc. In the old test I also targeted onto a higher surface to make the missile fly even higher, but that is not necessary to break TMD with UEF TML, it does so on a flat surface:
(Mavor for scale)
Some other distances:
These are the zapper effects you should look for:
It's weird that the zappers hit far more often when targeting the missile on the left side in my picture but not on the right.
Edit: More testing required.
Do you happen to know how to increase the hitbox for the missiles? I also found that the Zapper really misses a lot.
The hitbox is set based on the missile speed in faction-specific projectile scripts, for example: https://github.com/FAForever/fa/blob/c3978e6a7bdf46e1ce7c4516ad77a8d76a77e31d/lua/terranprojectiles.lua#L342
You have to search all files for that pattern to change them all. It's this way because we didn't get around to refactoring projectiles after rowey left.
Alright, thanks for your help.