Results 340 comments of Dan Gould

The tests are a great improvement in coverage as-is. I'm not even sure the missing checks are candidates for `ensure` other than "Verify that the payjoin proposal inputs all specify...

rats. This one needs rebase

Why are these strictly a v1 concern? `&mut response.bytes().await?.to_vec().as_slice()` seems to be how it's done in our app, and [`.bytes()` collects under the hood](https://docs.rs/reqwest/latest/src/reqwest/async_impl/response.rs.html#288-294). I want to make sure #586...

doesn't #586 only enforce send and not receive? Isn't this thus still open?

diff --git a/Cargo-minimal.lock b/Cargo-minimal.lock ```diff index ca59ec8..7848e9b 100644 --- a/Cargo-minimal.lock +++ b/Cargo-minimal.lock @@ -1689,6 +1689,7 @@ dependencies = [ "testcontainers-modules", "tokio", "tracing", + "tracing-log", "tracing-subscriber", "url", ] diff --git a/Cargo-recent.lock...

~~Checking `cargo tree`, I think tracing-subscriber is only used as a dev-dep with payjoin-directory, ohttp-relay, and testcontainers. I'm not opposed to adding it but I *do* think it would entail...

It seems like an Append Only Log is straightforward to implement while #364 Payjoin Directory changes is open and making the change. I suppose GET range headers and padding could...

I did an ugly refactor to get tests to pass and I'm sure I'm not doing best practice hyper v1 on [a5075da](https://github.com/payjoin/rust-payjoin/pull/290/commits/a5075da0096ff9a19d7001d1fe3adf55c3a0d293). In doing this change I also realized all...

I think `pj.bobspacebkk.com` is having a problem. Try another ohttp server and it should work. We've got to talk about OHTTP server hosters' reliability on Friday Clearly we need a...