Dan Gould
Dan Gould
@jonatack I believe I've addressed each of your comments in this last review. Thanks for the useful feedback. Your polish really elevates the reading experience.
Addressed comments requiring @jonatack's feedback, decided to stick with BIP 21 since that's the lowest common dependency, and imposed a requirement on fragment parameter order since it might impose a...
Nice lookin' draft. There are some code repeats that can probably be squashed but you probably know that and are just sharing early. I suppose this fixes #528? A mention...
I think I spoke imprecisely. The Internal Error should remain private. If it's time to make certain *variants* that are public, but keep an `Internal` Variant that's private, I think...
One fix would be to make the current InternalError into InternalErrorInner and then make a pub struct InternalError(InternalErrorInner). Otherwise, #[doc(hidden)] on both the Internal Variant **AND** pub enum InternalError could...
Ah, and in that case it makes sense to test only with v1 compiled. Needs further investigation I suppose.
> v2 receiver is still technically not backwards-compatible because we can't guarantee the same behavior for other v1 sender implementations Can you expand on this? How would you expect of...
Another way to make v1 senders fail v2 urls would be to display an `http://` url by default, since authenticated encryption is done using HPKE and rather than TLS and...
if it were just logged as warn I think that would make me less concerned in the place it does crop up in ci logs. Is that an appropriate change...