rust-payjoin icon indicating copy to clipboard operation
rust-payjoin copied to clipboard

Upgrade rustls v0.22.4

Open DanGould opened this issue 1 year ago • 1 comments

This is going to require moving payjoin-directory to hyper-1.+ In order to get the rustls-0.22.4 support in hyper-rustls

This fixes a bug in payjoin-directory and should be followed by an updated deployment of that crate.

  • first patch applies crate updates
  • second patch limits compilation in v2 mode where hyper deps aren't needed by adding a v1 feature and making some deps optional

DanGould avatar Jun 17 '24 00:06 DanGould

I did an ugly refactor to get tests to pass and I'm sure I'm not doing best practice hyper v1 on a5075da. In doing this change I also realized all of the hyper server dependencies are being brought in even when payjoin-cli/v2 is enabled, so it might be a good time to look into whether or not they can be switched off when the v2 cli is being used.

DanGould avatar Aug 09 '24 23:08 DanGould

I think pj.bobspacebkk.com is having a problem. Try another ohttp server and it should work. We've got to talk about OHTTP server hosters' reliability on Friday

Clearly we need a better Error message for the proxy server when a proxied CONNECT fails

DanGould avatar Aug 14 '24 21:08 DanGould

Ok I was just going to add I'm running into the same issue on master. It works with a different ohttp server.

spacebear21 avatar Aug 14 '24 21:08 spacebear21

Just rebased to fix the Cargo.lock config

DanGould avatar Aug 14 '24 21:08 DanGould

and removed a hanging TODO

DanGould avatar Aug 14 '24 21:08 DanGould