Results 340 comments of Dan Gould

Just rebased to fix the Cargo.lock config

and removed a hanging TODO

Are you suggesting I compile the changes into an addendum document, or something else?

> I'd still like to cover the edge case I mentioned because it affects some software in the wild but that can be done in a separate PR. To be...

Here is a [bitcoin core payjoin client](https://github.com/DanGould/rust-payjoin/tree/master/payjoin-client) as a reference

> Why would a sender agree to receiver consolidation if it might compromise their own privacy? Consolidation is necessary to spend amounts greater than individual TXO values. If it can...

This commit [ec2bf55ac80f87004c882c9c8e12b954ba286a29](https://github.com/LtbLightning/payjoin-flutter/commit/ec2bf55ac80f87004c882c9c8e12b954ba286a29) is payjoin-flutter 0.23. still hoping to get some feedback from @StaxoLotl on https://github.com/LtbLightning/payjoin-flutter/pull/55 to get the dependency changes in if necessary

No, this issue is NOT closed by e117c000cdbed55207fbc52d1437240b260e88f0 The branch release/v0.23.0-dev.1 was opened by @StaxoLotl to update build dependencies. it does NOT update the underlying payjoin wire protocol, which is...

Couldn't the field clearing and `apply_fee` order be reversed to fix this problem?

We should be able to estimate the sender's P2SH weight with [`InputWightPrediction::new`](https://docs.rs/bitcoin/latest/bitcoin/transaction/struct.InputWeightPrediction.html#method.new), however receiver inputs may not yet have the witness element length (because they're not signed before `apply_fee` so...