Dan Gould

I believe adding this test brings k256 up to feature parity with the others. Is anything else blocking it from being merged into main as a feature? Linking to the...

pretty massive delete! eager to follow

I'm partial to allow mixed input types, and that opinion appears to be [consensus](https://github.com/bitcoin/bips/pull/1244). In addition, allow by default is more permissive and should have fewer failed attempts, I'm not...

- Try_fold fix looks good - input_type and sequence removal also looking good I haven't checked the PSBT values in the known-weight tests, so I'm on that tomorrow. I think...

Full transparency this is NOT shaped up for code review. The first push serves as a bookmark for us to get to work making the integration work. We'll clean up...

Thanks for the check @kilrau. We did release [payjoin-0.24.0](https://crates.io/crates/payjoin/0.24.0) to solve the persistence problems written up in [this discussion](https://github.com/orgs/payjoin/discussions/689#discussioncomment-13078942) last week, so the technical roadblocks to an integration are removed....

> what do you think is a reasonable expiration time - TBH I think 6 months is more like it, especially if Bitcoin Core clients cache the OhttpKeys from having...

There we go. I knew there was some straightforward way that'd just make sense that would require encoding / json complexity

> every single ensure! in basic_checks, check_inputs, check_outputs and check_fees, should have a corresponding unit test — @spacebear21 https://github.com/payjoin/rust-payjoin/pull/505#discussion_r1927082146

The checklist appears to be just for the sender. Are you satisfied that the receiver is sufficiently covered by adversarial tests @spacebear21