Dan Gould

Beware that reviewing this may not be top priority before payjoin-1.0 milestone closes, but I do think you have the chops to take it on after having worked on the...

~~This is also the case in rust-bitcoin as far as I can tell, and I'm confused about it.~~ false alarm, only our lock files are incorrect, so we can learn...

Looks like Rust-bitcoin is actually only using the script to update Cargo-minimal.lock and Cargo-recent.lock actually requires manual intervention, evidenced by https://github.com/rust-bitcoin/rust-bitcoin/issues/2844 and https://github.com/rust-bitcoin/rust-bitcoin/issues/3311

Thanks for stepping up. go for it @Johnosezele

> V2PostContext is not a typestate and has no place in the session sumtype understood. Thanks for clearing that up. > Isnt v1 a common? No. Only `WithReplyKey` has a...

I think the way to clean the separation between v1/v2/multiparty is to acknowledge the the PsbtContext rules are largely the same, so keep those. Rather than have v2 inherit v1,...

Another oddity I found is that the `v2::SenderBuilder` produces both an event (which can itself be success or failure), AND the sender itself, although the successful SessionEvent also contains the...

I suppose the transition is necessary to go from `SendSession::Uninitialized` to the next state. Understood.

if the error part of `MaybeBadInitInputsTransition` is not persisted then I don't think we ever need to include it as part of the transition. The error can be handled by...

i see. The InitialTransition state is a special case where both the event and NextState are ~the same data.