rust-payjoin
rust-payjoin copied to clipboard
Limit response sizes for v1
Add content length checks in v1 send and payjoin-cli.
Fixes #483
Pull Request Test Coverage Report for Build 15169166399
Details
- 41 of 48 (85.42%) changed or added relevant lines in 2 files are covered.
- 2 unchanged lines in 1 file lost coverage.
- Overall coverage increased (+0.09%) to 83.525%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| payjoin/src/send/error.rs | 0 | 2 | 0.0% |
| payjoin/src/send/v1.rs | 41 | 46 | 89.13% |
| <!-- | Total: | 41 | 48 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| payjoin/src/send/error.rs | 2 | 39.72% |
| <!-- | Total: | 2 |
| Totals | |
|---|---|
| Change from base Build 15167733837: | 0.09% |
| Covered Lines: | 5947 |
| Relevant Lines: | 7120 |
💛 - Coveralls
I found the comment in receive for the "why" but it seems to have been removed, IMO i would like it to be included somewhere
// 4M block size limit with base64 encoding overhead => maximum reasonable size of content-length
rats. This one needs rebase
done 👍🏼