Dan Gould
Dan Gould
@NicolasDorier This issue cropped itself up in Sparrow wallet too, where sparrow won't sign based solely on an outpoint but requires the utxo scripts to sign. https://github.com/sparrowwallet/sparrow/issues/1428 It would be...
My guess was that the spec was written this way out of convenience for the original NBitcoin / BTCPayServer implementation. The [BTCPayServer sender calls `proposedPayjoin.SignAll`](https://github.com/btcpayserver/btcpayserver/blob/e5a09cbeaa48ce9fca258a7c3848ad5df0898bf8/BTCPayServer/Controllers/UIWalletsController.PSBT.cs#L506). By excluding the utxo fields...
Don't hesitate to reach out with questions to clarify of if you need help. I recommend checking out the BTCPay sender updates to get an idea of what to do....
The input check was meant to be against your counterparty. Even combining P2WSH P2WPKH should have triggered an error before this change if the receiver was using P2WSH and Wasabi...
It would be sealed and we'd implement it for &'a str, &'a String and String just like reqwest.
I realize now that `reqwest` also [re-exports `url::Url`](https://docs.rs/reqwest/latest/reqwest/struct.Url.html), which is nice for convenience. There are circumstances where you want to parse URLs early, as in payjoin-cli configuration, and having the...
This is somewhat covered by #520, we're not going to remove url::Url (immediately), but we are using `IntoUrl` to make the signatures more ergonomic. Whether we want to depend on...
While #1057 removed the use of Url in function arguments, it's still in the public API. Reopening A typesafe future proof solution would be to introduce ```rs struct Url(url::Url); impl...
Noted un-completed by #1141
closed by #1141