Bronek Kozicki

> @ximinez or @Bronek or @mvadari - could you have a quick look to see if the "2 lines in your changes are missing coverage" would be easy to address?...

> > @ximinez or @Bronek or @mvadari - could you have a quick look to see if the "2 lines in your changes are missing coverage" would be easy to...

> > (cc @Bronek to double check since he's already taken a look at some of the code) Thank you @intelliot ; I looked some more and there is one...

I am starting to think that writing this to the existing perflog would be a decent solution: * the data gets persisted between restarts etc. * we get to use...

As of today, the most recent rocksdb version [supported by conan](https://conan.io/center/recipes/rocksdb) is 8.8.1 ; it is a relatively fresh version, [released Nov 2023](https://github.com/facebook/rocksdb/releases/tag/v8.8.1), there are no newer [8.8.x](https://github.com/facebook/rocksdb/tree/8.8.fb) [releases](https://github.com/facebook/rocksdb/tags) at...

FWIW I did start work for upgrade to 8.8.1 (just as @thejohnfreeman said - just upgrade version in `conanfile.py` ), found compilation error and moved on to other priorities.

Also, by "currently" I actually mean since https://github.com/XRPLF/rippled/pull/4775

@gregtatcam do you think that's something we ought to change in `rippled` ?

I think this is because in `rippled` we **first** execute this check: ``` if ((params.isMember(jss::asset) != params.isMember(jss::asset2)) || (params.isMember(jss::asset) == params.isMember(jss::amm_account))) return Unexpected(rpcINVALID_PARAMS); ``` In this case indeed both `asset`...

I will prepare a PR to change the order of checks in `rippled` for API version 3. As for API version 2 I think we just need to document the...