Bronek Kozicki

@mtrippled @bthomee I was able to merge `develop` to this branch while resolving a merge conflict.

I investigated the link error due to duplicate definition of `__cxa_allocate_exception`. We have three options to fix it: * Do not upgrade to 1.86.0 ; instead upgrade only to 1.84.0...

instrumentation error should be fixed with https://github.com/XRPLF/rippled/pull/5607 , or by cherry-picking https://github.com/XRPLF/rippled/pull/5606/commits/2ea247bb9c3d57a9e665c868ff1019f58e313ac5

@tequdev would you like to create a new PR to switch `Supported::no` to `yes` for this amendment, before the 3.0.0 release ?

Fixing it would require an amendment, but it should be fixed. We cannot have expired offers stored indefinitely on the ledger.

> @Bronek Any outstanding issues for @ximinez to address? Yes, just added some. The loop and callback inside critical section can be probably resolved with an explanation e.g. a comment...

Merge memo: history rewritten and base branch changed to `develop` after #5224 has been merged to `develop` Initial stage of reconciliation in commit https://github.com/XRPLF/rippled/commit/f041036df1634afdc89cdba12f0a589ac8463f5f ``` (git)-[ximinez/lending-XLS-66] % git log --oneline...

@dangell7 @shawnxie999 I have merged `develop` at 0a34b5c691 (ie. with #5060 and #5404 changes) into this open PR, in commit https://github.com/XRPLF/rippled/pull/5270/commits/cc83ea8eb6618ee65c18067bd2ac3ddf61e8cecc (the link will show resolution of merge conflicts). This...

@dangell7 Find a Windows equivalent and use as appropriate, please

Can you pls also increase the unit test coverage here ? No need to go through `Env` , just create `XRPAmount` with inputs to cover all the interesting cases. This...