Bronek Kozicki
Bronek Kozicki
https://github.com/XRPLF/rippled/pull/5042 is blocked by this PR
I like how you moved `extract` to appropriate locations, but it seems that `extract` is function-wise the same as `hash`. Given we already specialize both `boost::hash` (e.g. in `IPEndpoint.h`) and...
I do wonder whether `Builds/levelization` is becoming superfluous with this change. Why should we keep it, if the ordering of modules (and header isolation) enforce it for us ?
> `Builds/levelization` is still used to diagnose cycles in xrpld. I want to remove it after we've eliminated all of the cycles. Makes sense. All the more reason to make...
This PR increases overall test coverage of the project by 0.10% , to 78.10% , which is really nice - thank you @mvadari !
> Is it just me, or do these changes not actually change any behavior? > > In `InboundLedgers::acquireAsync()`, we have this sequence before: > > * 142: `unlock()`. > *...
> This may be redundant with the `CanProcess` class in #5126. I'm biased, but I prefer my solution because it hides all the locking in a single class. I'm open...
https://github.com/XRPLF/rippled/pull/5042 is blocked by this PR
@a1q123456 you can fix the formatting errors with ``` find src include -type f \( -name '*.cpp' -o -name '*.hpp' -o -name '*.h' -o -name '*.ipp' \) -exec clang-format -i...
> So example in the opposite direction of the one initially added. We have 20 lists (each with 20+ nodes on them) that are use to compose the UNL only...