Bronek Kozicki
Bronek Kozicki
I recommend waiting until https://github.com/XRPLF/rippled/pull/5112 is merged **and released** ; without this change, any additional UNL publisher will reduce the security of the UNL system
What's your base OS ? The compiler versions selected are ancient.
@legleux we don't care about gcc-11 and clang-14 anymore, just delete these profiles. It's clutter now.
What's the reason to remove workflows: * `clang-format` * `doxygen` * `levelization` * `libxrpl` * `missing-commits` ? If that reason is lack of appropriate container, then container shall be created...
> > @bthomee The first line of this PR was to update to "Conan 2 as minimally invasive as possible." With the requests to update the pipeline steps, actions, update...
@MarkusTeufelberger we are considering refreshing RocksDB dependency to a more recent version (it will require code changes), would that help with the last point ?
> I still see `History Sharding` from this [link](https://xrpl.org/docs/concepts/networks-and-servers/ledger-history#history-sharding). Is it the same thing removed in #5066 🤔 ? Yes. It wasn't working very well and added fair amount of...
@BajanWave thank you for volunteering to increase our unit test coverage; please see the change I made in `Credentials_test.cpp` in https://github.com/XRPLF/rippled/pull/5935/commits/759415afa64812c00fb2a8dd1e8e7e134fd79fd7#diff-d7897e33a8fc2faf3303c3179605aaf75e0385a5275a3fd0fa420a67c7c7072c as an example of a unit testa I'd like...
> Test Plan Tested following reference fee values: 10, 20, 50, 100, 200, 500, 1000 by changing https://github.com/vvysokikh1/rippled/blob/2f432e812cb773048530ebfaf2e0e6def51e3cc2/src/test/jtx/impl/envconfig.cpp#L47 Can you pls add a command line option to set this value...
> > > Test Plan Tested following reference fee values: 10, 20, 50, 100, 200, 500, 1000 by changing https://github.com/vvysokikh1/rippled/blob/2f432e812cb773048530ebfaf2e0e6def51e3cc2/src/test/jtx/impl/envconfig.cpp#L47 > > > > > > Can you pls add...