Bronek Kozicki
Bronek Kozicki
nice ! @yinyiqian1 do you agree this is ready to merge ?
@mDuo13 I think this PR does not require change in `API-CHANGELOG.md` because the erroneous behaviour being fixed here is not documented nor makes practical sense to use. Your opinion ?
FWIW, ~I am uncomfortable with this change. Both `STCurrency` and `STIssue` are basic protocol building blocks, and because of this we cannot assume that `isDefault()` functions will be only ever...
> > FWIW, I am uncomfortable with this change. Both `STCurrency` and `STIssue` are basic protocol building blocks, and because of this we cannot assume that `isDefault()` functions will be...
> `return (mValue == 0) && mIsNative;` I think the condition that you are citing here just happens to match the definition of "no useful data here", in the context...
> This method [RPC::getLedgerByContext](https://github.com/XRPLF/rippled/blob/c19a88fee9cd5b034a2fbcc013416afc10464e35/src/xrpld/rpc/detail/RPCHelpers.cpp#L1031) takes up a lot of time to retrieve an old ledger. This method is used only in RPC calls `book_changes` and `ledger_request`. The purpose of the...
@shortthefomo we will close this now because it has not been updated in a long time, but feel free to bring a new PR to fix this same problem. It...
Hi @ckeshava , it would be great if you could: 1. update this branch from the current `develop` and 2. act on this feedback from @mounikakun > Also Clio do...
@godexsoft you might want to test this branch with clio.
> What do you mean by USER context? I feel the `getLedgerByContext` should only be used by the consensus mechanism (and Full History Nodes) to collect+store all ledgers. Its in-efficient...