Bronek Kozicki
Bronek Kozicki
Note, showing extra fields in responses is fair play; especially if these fields are not documented (so they do not officially fall into API interface). I do not think you...
@godexsoft there will be change in API when `rippled` version 2.0 is released. Since we will need to release `clio` with matching API changes, this seems like a good opportunity...
The choice of cmake option name `voidstar` comes from the reference to `libvoidstar.so` in the implementation of the Antithesis instrumentation - which is inside `external/antithesis-sdk/antithesis_instrumentation.h` file. I am open to...
> 6 validators is a good start and should yield useful results. > > But just curious, how difficult would it be to later scale up the test to 35...
> Am I correct in guessing that all of the edits under `include/` and `src/` are just changing assertions to use the new macros? Yes.
> > Am I correct in guessing that all of the edits under `include/` and `src/` are just changing assertions to use the new macros? > > Yes. @thejohnfreeman not...
> @Bronek Before I merge this, can you write a commit message with a consise summary? Add Antithesis instrumentation * Copy Antithesis SDK version 0.4.0 to directory external/ * Add...
While you are at it, I see that `account_objects` has pretty good unit test coverage but it could be still improved. See the red line 274 in https://app.codecov.io/gh/XRPLF/rippled/blob/develop/src%2Fxrpld%2Frpc%2Fhandlers%2FAccountObjects.cpp and red...
> > While you are at it, I see that `account_objects` has pretty good unit test coverage but it could be still improved. See the red line 274 in https://app.codecov.io/gh/XRPLF/rippled/blob/develop/src%2Fxrpld%2Frpc%2Fhandlers%2FAccountObjects.cpp...
@yinyiqian1 I allowed myself to merge the current `develop` to your branch, since it was presenting a confusing diff in `API-CHANGELOG.md` . Hope you do not mind.