Bronek Kozicki
Bronek Kozicki
Please kindly re-format this PR, as per to https://github.com/XRPLF/rippled/blob/develop/CONTRIBUTING.md#formatting Note, we are using old clang-format-10, but it's trivial to setup with the help of containerised ubuntu:20.04 (https://packages.ubuntu.com/focal/clang-format-10 )
Also, this PR seems to be removing existing comments from the codebase in a rather arbitrary manner, please do not do that without a good reason.
Closed due to author's inactivity
> `DeliverMax` should be added to `server_definitions`, same as `DeliverMin` is there. What @dangell7 has said. I will also add that `DeliverMax` is not a field; it is an alias...
> 1. Set a breakpoint in gdb/lldb in whatever transactor you're investigating Reminder that `Transactor::trapTransaction` was specifically created to provide a convenient location for such breakpoint, in case if you...
Thank you @RomThpt , this PR looks like a good effort, I am going to enable workflows so we can see how it actually improves unit test coverage.
@mvadari do you want help merging from `develop` to your branch ?
> To be clear, this is set to go into `rippled` version 3.0.0, not version 2.6.0 which is the next planned release? Yes. Although the changes are in release 2.6.0,...
@mvadari we would normally upload our custom recipes to https://github.com/XRPLF/conan-center-index