rippled icon indicating copy to clipboard operation
rippled copied to clipboard

Upgrade rocksdb

Open Bronek opened this issue 1 year ago • 4 comments

Summary

Upgrade rocksdb to a more recent version

Motivation

We are currently using version 6.29 which was released in the first half of 2022. The most recent version of rocksdb is 9.9.1 . There might have been useful for us improvements in this more recent version, e.g. related to performance.

Solution

Upgrade and test

Bronek avatar Jan 17 '24 16:01 Bronek

As of today, the most recent rocksdb version supported by conan is 8.8.1 ; it is a relatively fresh version, released Nov 2023, there are no newer 8.8.x releases at this time.

Bronek avatar Jan 25 '24 11:01 Bronek

Most recent RocksDB version is 9.1 https://github.com/facebook/rocksdb/releases/tag/v9.1.0

Is version 6.X considered end-of-life and should it be still used?

onny avatar Apr 22 '24 10:04 onny

We don't count on support for dependencies, so end-of-life doesn't matter. If you (or someone else watching) wants to take a stab at updating the dependency, just change the version number in conanfile.py and try to build. If it builds and passes tests without issue, great! Otherwise, work will be needed to change our code to use the new API, whatever it is. We're not budgeting time to work on this right now.

thejohnfreeman avatar Apr 23 '24 14:04 thejohnfreeman

FWIW I did start work for upgrade to 8.8.1 (just as @thejohnfreeman said - just upgrade version in conanfile.py ), found compilation error and moved on to other priorities.

Bronek avatar Apr 23 '24 19:04 Bronek