Jacob Walls

Results 441 comments of Jacob Walls

Running a project test suite against this PR produces this failure; setting PNI until I can add a test: ```py File "/Users/.../django/django/db/backends/base/schema.py", line 1162, in _alter_field actions = [(", ".join(sql),...

I think `chain()` would be more resilient against third-party migrations operations? Interestingly, `()` for `start` still reveals failures, e.g. from the return of `_alter_column_null_sql`. I guess I should fix that...

> I guess I should fix that while here. Stopped short of doing this; don't want to blow up the scope here. For posterity I had a draft like this:...

Thanks for the updates. What I'm noticing is that the tests still enumerate all of the properties by hand, instead of generating the list of test cases from `models.options.Options`. Earlier...

> Quick question: Do you think the newly revised tests I added provide any additional value, or are there already existing tests that cover those cached properties? They do a...

The datatype defaults to semantic, so it shouldn't be an issue.

> Added backport label because we'll need 3.14 compat for pylint faster than we can properly release 4.0.0. Maybe worth kicking this around in the discord #release-planning channel? I could...