Jacob Walls

Hi @mradamcox the failing build is because this PR targeted master. Although it's the default branch in the repo, we don't target PRs to it. Because this fixes an issue...

Oh, one more thing. At the developer meeting last week it was encouraged to make the changelog update as part of a PR. A bullet in the 7.5.2.md document would...

Hey, thanks for tackling this one! What do you think about something like this? ```diff diff --git a/pylint/checkers/typecheck.py b/pylint/checkers/typecheck.py index edef5188b..afed2d3fe 100644 --- a/pylint/checkers/typecheck.py +++ b/pylint/checkers/typecheck.py @@ -1453,8 +1453,19 @@...

Hey @jzohrab that would be great. Once you get a clean test run (I think I remember seeing there were a couple functional tests that needed updating?) the CI will...

Hey thanks for the push. What I can say at a glance is that the pylint annotations you see in the files tab of this PR show some false positives...

@Antoliny0919 👋 I can turn my attention this in the near term. Fancy cleaning up the merge conflicts? And maybe let me know what in your view the outstanding questions...

Thanks @Antoliny0919! Sarah asked me to push this one forward. Unfortunately, I'm using VoiceOver on Safari and despite declared support for reading out "current page" during navigation, I can't see...

Looks like there was prior inconsistency around whether final breadcrumb items should be (or even are allowed to be) links: https://github.com/w3c/aria-practices/issues/3047. The outcome of that discussion was to _allow_ them...

Thanks for engaging in discussion. Let us know if the nodes_of_class() solution doesn't work well for you.

Including `x2` in locals makes sense to me, as it's what happens at runtime (the whole point of the nonlocal keyword being to add a not-otherwise-local to the locals): ```py...