Jacob Walls

Results 432 comments of Jacob Walls

Hi @areveny, just wondering: are the false negatives in the primer result one of the items you were hoping to polish after getting an initial review?

Thanks for the report. Would you like to submit your proposed solution?

Thanks for looking into it. If the flag is temporary to give us time to evaluate the total effect, +1 from me.

I like `unguarded-typing-import`. I think the check makes sense, at least as much sense as vanilla unused-import. You can have bugs from depending on the coincidental importing of one module...

This should definitely be off by default (and to be clear when I say do away with the concept of extensions, I don't mean _turn everything on_, I mean replace...

> Pylint has a lot of refactoring messages where nothing is strictly wrong. `no-else-return` is a good example. Recently a core python committer asked me to insert `else:` before a...

We added `default_enabled` in #7629, but we may not be using it in all the places we should yet (e.g. until we fully implement #3512).

I think we still want the primer to test all checks, so we can make the most informed decisions when reviewing features and fixes.

We already did this for the --pattern option.