Jacob Walls

Results 441 comments of Jacob Walls

Thanks for your patience @GappleBee, I just squashed and pushed tiny edits.

Thanks y'all for reviews, I incorporated that feedback. And thank YOU @GappleBee for being so diligent throughout the process. I count **10 authors and reviewers** in the commit message. I...

Worth testing how this affects the `pkg` directory

Thanks for the report. Reproduced with two string nodes. Error happened when performing the same action (select map card) on the second string node. trace: ```js Error: The argument passed...

I think the patch is just: ```diff diff --git a/pylint/checkers/variables.py b/pylint/checkers/variables.py index 32ec31809..e8d12eebb 100644 --- a/pylint/checkers/variables.py +++ b/pylint/checkers/variables.py @@ -1363,7 +1363,11 @@ class VariablesChecker(BaseChecker): checks globals doesn't overrides builtins. """...

Exactly. The spirit of the message as I understand it is to discourage that kind of exact check.

We should add an exception for uses inside `__eq__(self, other)`. A lot of the primer cases are coming from traffic like that.