astroid icon indicating copy to clipboard operation
astroid copied to clipboard

[ci] Start testing on python 3.14-beta

Open Pierre-Sassoulas opened this issue 6 months ago • 6 comments

Type of Changes

Type
:sparkles: New feature

Pierre-Sassoulas avatar May 08 '25 18:05 Pierre-Sassoulas

I've been looking into the brain errors. Will open a PR to fix them later today.

cdce8p avatar May 15 '25 12:05 cdce8p

Rebased the PR and fixed the remaining two test cases. Just wondering if we need to split the as_string case. On my machine (macOS ARM) I'm also seeing outright Python crashes for two test cases. The CI run seems to be fine though.?

Both are already ignored for PyPy. When I run them locally, Python crashes with Abort trap: 6

  • tests/test_inference.py::InferenceTest::test_no_infinite_ancestor_loop
  • tests/test_inference.py::test_recursion_on_inference_tip

-- Also seeing a crash for one pylint test

  • tests/test_functional.py::test_functional[regression_5408]

cdce8p avatar May 16 '25 16:05 cdce8p

Just wondering if we need to split the as_string case.

I was trying to keep the return in finally for python < 3.14 but it's near impossible (very hard as we have 188 tests using it, we can't remove them all for python 3.14). Probably not something we're going to break by mistake, so probably safe to skip.

Pierre-Sassoulas avatar May 16 '25 20:05 Pierre-Sassoulas

My current guess with the last issue is either a fail of pytest under windows and python 3.14 or a cache issue on our side.

Pierre-Sassoulas avatar May 17 '25 05:05 Pierre-Sassoulas

Added backport label because we'll need 3.14 compat for pylint faster than we can properly release 4.0.0.

Pierre-Sassoulas avatar May 17 '25 05:05 Pierre-Sassoulas

Added backport label because we'll need 3.14 compat for pylint faster than we can properly release 4.0.0.

Maybe worth kicking this around in the discord #release-planning channel?

I could also envision us committing to spending our limited effort between now and October 1 on nothing but 3.14 compat (and optionally, possibly the simplest MVP of pylint-dev/pylint#3512) and releasing 4.0 by October 1. I think we should ship the new features people have contributed without waiting for too much else.

jacobtylerwalls avatar Jun 07 '25 13:06 jacobtylerwalls

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 93.31%. Comparing base (e0a7642) to head (b19868d). :warning: Report is 106 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2731      +/-   ##
==========================================
+ Coverage   93.29%   93.31%   +0.01%     
==========================================
  Files          92       92              
  Lines       11051    11051              
==========================================
+ Hits        10310    10312       +2     
+ Misses        741      739       -2     
Flag Coverage Δ
linux 93.18% <ø> (+0.01%) :arrow_up:
pypy 93.31% <ø> (+0.01%) :arrow_up:
windows 93.29% <ø> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jul 13 '25 08:07 codecov[bot]