Jacob Walls
Jacob Walls
You did identify a real issue -- annotated statements at the module level are completely escaping any sort of checking for invalid-name -- that can't be right!
We can discuss what to do in finer-grained detail for these cases in #3585, but for now, suggest to just make `my_var: int` do the same check as `my_var`.
Not a regex but something more like a refactor to let the invalid name check do "as-if" checks so a name can be checked twice against two regexes. But yeah,...
Hm, if the other change is waiting for 4.0 are we willing to let this wait that long also?
Thanks for being so responsive to the reviews. This pull request languished outside the patch review queue because the ticket's "needs improvement" flag was never unset. I'm unsetting it right...
I think @carltongibson is onto something, see a similar 3.14 fix in coverage 7.9.2: https://github.com/coveragepy/coveragepy/issues/1991 The latest run at djangoci.com used `coverage==7.11.3`, so we may have found another case to...
After looking closer, I think it's the other PR (#19366) with the `except*` usage. Opened https://github.com/coveragepy/coveragepy/issues/2086
Cool stuff @alexprabhat99! We're still discussing the merit of the idea, but I'm wondering if you'd be game to try to add some sort of exception for calls inside `def...
Feel free to reopen if you return to this.
Closing in favor of #19519